fix(http): avoid running out of memory when importing partitioned table over REST API #3638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puzpuzpuz
added
Bug
puzpuzpuz
force-pushed
the
puzpuzpuz_max_uncommitted_rows_in_imp_endpoint
branch
from
a86244c
to
1c6c91d
Compare
[PR Coverage check]😍 pass : 16 / 18 (88.89%) file detail
|
bluestreak01
approved these changes
Aug 14, 2023
bluestreak01
deleted the
puzpuzpuz_max_uncommitted_rows_in_imp_endpoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3480
By default, the POST
/impREST API endpoint doesn't issue intermediate commits. This PR makes sure that we initializemaxUncommittedRowsando3MaxLagparameters of theCairoTextWriterwith the table's defaults, so thatwriter.ic()calls are made during the import. As a result, the O3 memory won't be unboundedly growing when importing O3 data and chances to run OOM become much smaller.Also improves timestamp unit description in
Sender's Javadoc