Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql): fix alter table dedup enable syntax #3643

Merged
merged 4 commits into from
Aug 14, 2023

Conversation

ideoma
Copy link
Collaborator

@ideoma ideoma commented Aug 14, 2023

Both syntax variants are made valid

ALTER table abc DEDUP ENABLE UPSERT KEYS(a, b);

ALTER table abc DEDUP UPSERT KEYS(a, b);

Also fixed a bug where table was not shows as dedup enabled in tables() query when the timestamp index is 0.

@ideoma
Copy link
Collaborator Author

ideoma commented Aug 14, 2023

[PR Coverage check]

😍 pass : 17 / 17 (100.00%)

file detail

path covered line new line coverage
🔵 io/questdb/griffin/engine/functions/catalogue/TableListFunctionFactory.java 2 2 100.00%
🔵 io/questdb/cairo/DedupColumnCommitAddresses.java 3 3 100.00%
🔵 io/questdb/griffin/SqlCompilerImpl.java 2 2 100.00%
🔵 io/questdb/cairo/TableWriter.java 1 1 100.00%
🔵 io/questdb/griffin/SqlKeywords.java 9 9 100.00%

@ideoma ideoma merged commit 1443525 into master Aug 14, 2023
21 checks passed
@ideoma ideoma deleted the fix-alter-dedup-enable-syntax branch August 14, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants