Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql): fix implicit type casting in coalesce() function #3647

Merged
merged 3 commits into from
Aug 14, 2023

Conversation

bziobrowski
Copy link
Contributor

Fixes #3622
Also fixes :

  • select typeOf(ipv4_expression)
  • implicit cast between string and ipv4 types

@ideoma
Copy link
Collaborator

ideoma commented Aug 14, 2023

[PR Coverage check]

😍 pass : 6 / 6 (100.00%)

file detail

path covered line new line coverage
🔵 io/questdb/griffin/engine/functions/conditional/CaseCommon.java 2 2 100.00%
🔵 io/questdb/griffin/ExpressionParser.java 1 1 100.00%
🔵 io/questdb/griffin/engine/functions/catalogue/TypeOfFunctionFactory.java 1 1 100.00%
🔵 io/questdb/griffin/engine/functions/conditional/CoalesceFunctionFactory.java 2 2 100.00%

@bluestreak01 bluestreak01 merged commit 0afe054 into master Aug 14, 2023
21 checks passed
@bluestreak01 bluestreak01 deleted the bz_fix_coalesce branch August 14, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnsupportedOperationException in IntFunction.getStr(IntFunction.java:145)
3 participants