-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(http): make HTTP text import for WAL tables to write via WAL #3648
Conversation
Conflicts: core/src/main/java/io/questdb/cutlass/text/CairoTextWriter.java
[PR Coverage check]😍 pass : 70 / 73 (95.89%) file detail
|
Looks like as a side effect of this change, the serial mode of SQL COPY also started writing to WAL. Probably, it's worth it to add some tests around it. As for the parallel mode where we require the table to be empty, we should at least document that it writes to the end table instead of WAL and/or create a separate GH issue. WDYT? |
Hmm, I forgot that it's used for non-partitioned tables, so it's not applicable to WAL tables. On WAL tables COPY should be parallel always. |
REST
imp
endpoint was not updated to write to WAL tables using WAL infrastructure. This PR makes the writing to behave as expected. Also fixes #3632