Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sql): fix wrong results returned from union queries with similar joins #3768

Merged
merged 7 commits into from Sep 29, 2023
Merged

fix(sql): fix wrong results returned from union queries with similar joins #3768

merged 7 commits into from Sep 29, 2023

Conversation

puzpuzpuz
Copy link
Contributor

@puzpuzpuz puzpuzpuz commented Sep 21, 2023 •
edited

Fixes #3581
Fixes #3669

Fixes isolation for the lookup maps used in join optimizations (see comments in the added tests).

@puzpuzpuz puzpuzpuz added Bug Incorrect or unexpected behavior SQL Issues or changes relating to SQL execution labels Sep 21, 2023
@puzpuzpuz puzpuzpuz self-assigned this Sep 21, 2023
@puzpuzpuz puzpuzpuz marked this pull request as draft September 21, 2023 17:50
@puzpuzpuz puzpuzpuz marked this pull request as ready for review September 21, 2023 18:44
@puzpuzpuz puzpuzpuz marked this pull request as draft September 21, 2023 18:56
@puzpuzpuz puzpuzpuz marked this pull request as ready for review September 25, 2023 11:05
@ideoma
Copy link
Collaborator

ideoma commented Sep 27, 2023

[PR Coverage check]

😍 pass : 27 / 37 (72.97%)

file detail

path covered line new line coverage
🔵 io/questdb/griffin/model/RuntimeIntervalModelBuilder.java 18 28 64.29%
🔵 io/questdb/griffin/engine/union/IntersectRecordCursor.java 1 1 100.00%
🔵 io/questdb/griffin/SqlOptimiser.java 8 8 100.00%

@bluestreak01 bluestreak01 merged commit 4797f83 into master Sep 29, 2023
21 checks passed
@bluestreak01 bluestreak01 deleted the puzpuzpuz_intersect_query_eval branch September 29, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluestreak01 bluestreak01 bluestreak01 approved these changes

Assignees

@puzpuzpuz puzpuzpuz

Labels
Bug Incorrect or unexpected behavior SQL Issues or changes relating to SQL execution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect results returned from UNION Incorrect result returned by INTERSECT
3 participants
@puzpuzpuz @ideoma @bluestreak01