Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(http): large prometheus metrics responses split across multiple chunks #3843

Merged
merged 36 commits into from
Oct 26, 2023
Merged

fix(http): large prometheus metrics responses split across multiple chunks #3843

merged 36 commits into from
Oct 26, 2023

Commits on Oct 12, 2023

  1. It ain't workin' yet, but it sure ain't more broken.

    @amunra
    amunra committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    fda1a5c View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Got it working, leaving logging in for now while adding more test sce… 

    …narios.
    @amunra
    amunra committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    ef08240 View commit details
    Browse the repository at this point in the history

  2. moar testz

    @amunra
    amunra committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    7c69d96 View commit details
    Browse the repository at this point in the history

  3. pooling RequestState objects

    @amunra
    amunra committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    51c3184 View commit details
    Browse the repository at this point in the history

  4. Parallel metrics requests

    @amunra
    amunra committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    3b02931 View commit details
    Browse the repository at this point in the history

  5. Removed prometheus metrics processor logging.

    @amunra
    amunra committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    0497804 View commit details
    Browse the repository at this point in the history

  6. fixed a concurrency bug

    @amunra
    amunra committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    ce524e0 View commit details
    Browse the repository at this point in the history

  7. formatting

    @amunra
    amunra committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    90eb037 View commit details
    Browse the repository at this point in the history

  8. removal of unreachable code

    @amunra
    amunra committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    6bfc5ea View commit details
    Browse the repository at this point in the history

  9. cleaned up HttpChunkedResponse 'writeBytes' method

    @amunra
    amunra committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    7fd596f View commit details
    Browse the repository at this point in the history

  10. fixed potential overflow

    @amunra
    amunra committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    f641ce9 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. common request state pool for all prometheus processors

    @amunra
    amunra committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    256b7c9 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into chunked_response_me… 

    …trics
    @amunra
    amunra committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    6450385 View commit details
    Browse the repository at this point in the history

  3. Removed unused import

    @amunra
    amunra committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    fc5c5cf View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into chunked_response_metrics

    @amunra
    amunra committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    b91d9e2 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Merge remote-tracking branch 'origin/master' into chunked_response_me… 

    …trics
    @amunra
    amunra committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    1792690 View commit details
    Browse the repository at this point in the history

  2. Updated scrapable interface for metrics from CharSink to a new Utf8Di… 

    …rectCharSink which allows populating metrics from native code.
    @amunra
    amunra committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    0dc0687 View commit details
    Browse the repository at this point in the history

  3. comment tweak

    @amunra
    amunra committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    bde01c1 View commit details
    Browse the repository at this point in the history

  4. Fixed compile issues, improved naming.

    @amunra
    amunra committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    c0b762a View commit details
    Browse the repository at this point in the history

  5. feedback to use Files.PAGE_SIZE

    @amunra
    amunra committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    95fd287 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/master' into chunked_response_me… 

    …trics
    @amunra
    amunra committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    30a18cd View commit details
    Browse the repository at this point in the history

  7. removed todo

    @amunra
    amunra committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    6d76706 View commit details
    Browse the repository at this point in the history

  8. extra tests

    @bluestreak01
    bluestreak01 committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    a5d6a54 View commit details
    Browse the repository at this point in the history

  9. test and logic improvements, but now getting 'HttpException: bad prot… 

    …ocol'
    @amunra
    amunra committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    3a3d542 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Merge remote-tracking branch 'origin/master' into chunked_response_me… 

    …trics
    @amunra
    amunra committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    6bfaf19 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Fixed corner case where 'sendResponse' was being called repeatedly wi… 

    …thout making any progress.
    @amunra
    amunra committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    672bf83 View commit details
    Browse the repository at this point in the history

  2. Fixed writeBytes assertion to disallow len==0 and prevent similar bug… 

    … from happening again.
    @amunra
    amunra committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    1d46d9c View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into chunked_response_me… 

    …trics
    @amunra
    amunra committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    1936ff5 View commit details
    Browse the repository at this point in the history

  4. Added assertions on the prometheus RequestState pool size.

    @amunra
    amunra committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    b5ddd63 View commit details
    Browse the repository at this point in the history

  5. fixed merge issue

    @amunra
    amunra committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    d7ea28c View commit details
    Browse the repository at this point in the history

  6. code review improvements

    @amunra
    amunra committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    e23f817 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. Merge branch 'master' into chunked_response_metrics

    @amunra
    amunra committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    442e328 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into chunked_response_metrics

    @amunra
    amunra committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    194bae0 View commit details
    Browse the repository at this point in the history

  3. chore: small refactoring

    @bluestreak01
    bluestreak01 committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    14326f2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into chunked_response_metrics

    @bluestreak01
    bluestreak01 committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    c97a5b0 View commit details
    Browse the repository at this point in the history

  5. chore: fix leak

    @bluestreak01
    bluestreak01 committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    d33a981 View commit details
    Browse the repository at this point in the history