Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix database stuck on startup after some table drops #4152

Merged
merged 5 commits into from Jan 24, 2024
Merged

fix(core): fix database stuck on startup after some table drops #4152

merged 5 commits into from Jan 24, 2024

Conversation

ideoma
Copy link
Collaborator

@ideoma ideoma commented Jan 22, 2024

Some fuzz tests in CI were stuck because logging exceptions did not return the logging sequence.

@jerrinot jerrinot self-requested a review January 23, 2024 11:41
jerrinot
jerrinot requested changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@jerrinot jerrinot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like an object leak.

chances are I misunderstood the purge logic - it looks a bit convoluted (eg. the branch guarded by a timestamp comparison is unclear to me).

jerrinot
jerrinot previously approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@jerrinot jerrinot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to resolve my comment about double-purging. I am assuming purge is idempotent, I just wanted to make sure you are aware of this possibility.

@ideoma
Copy link
Collaborator Author

ideoma commented Jan 23, 2024

[PR Coverage check]

😍 pass : 18 / 19 (94.74%)

file detail

path covered line new line coverage
🔵 io/questdb/tasks/ColumnPurgeTask.java 0 1 00.00%
🔵 io/questdb/cairo/ColumnPurgeJob.java 15 15 100.00%
🔵 io/questdb/cairo/ColumnPurgeOperator.java 3 3 100.00%

@bluestreak01 bluestreak01 merged commit d2ec548 into master Jan 24, 2024
21 checks passed
@bluestreak01 bluestreak01 deleted the fix-database-stuck-on-start-after-table-drop branch January 24, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerrinot jerrinot jerrinot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ideoma @jerrinot @bluestreak01