feat(core): support WAL sequencer transaction file partitioned format #4194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: core/src/test/java/io/questdb/test/ServerMainTest.java
core/src/main/java/io/questdb/cairo/wal/seq/TableTransactionLogFile.java
Show resolved
Hide resolved
|
|
||
| import static io.questdb.cairo.wal.WalUtils.*; | ||
|
|
||
| public class TableTransactionLogV2 implements TableTransactionLogFile { |
There was a problem hiding this comment.
please document why two implementations are required
|
|
||
| long getPartNo(); | ||
|
|
||
| // Sets cursor to minimum available position. |
There was a problem hiding this comment.
terminology, it might be easier to use txn instead, such as min txn, vs minimum position etc
There was a problem hiding this comment.
renamed to toMinTxn()
Conflicts: core/src/test/java/io/questdb/test/ServerMainBackupDatabaseTest.java
Conflicts: core/src/main/java/io/questdb/cairo/DatabaseSnapshotAgentImpl.java
Conflicts: core/src/test/java/io/questdb/test/cairo/CairoEngineTest.java core/src/test/java/io/questdb/test/wal/WalTxnDetailsFuzzTest.java
[PR Coverage check]😍 pass : 668 / 724 (92.27%) file detail
|
bluestreak01
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WAL sequencer file
_txnlogrecords all 28 bytes per transaction and currently there is no way to reduce the space taken by this file. This can add up to many GiB of storage over time. This PR introduces new storage of_txnlogwhere it is chunked into multiple fixed-size files.The chunks or parts of
_txnlogare stored in_txn_partssubdirectory as files with numeric names:When all the transactions from the part are fully applied to the table, the part is deleted by
WalPurgeJob"Old" non-chunked sequencer files are fully supported. To switch for a new table to use chunked format a configuration option
cairo.default.wal.seq.chunk.txn.countto be set, for example to the value of 5000.Also, this change adds additional commit details to the sequencer log of the new format: