Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql): segfault when running SAMPLE BY query with index-based filter and last/first functions #4233

Merged
merged 5 commits into from Feb 27, 2024

Conversation

puzpuzpuz
Copy link
Contributor

@puzpuzpuz puzpuzpuz commented Feb 23, 2024

Fixes #4232

@puzpuzpuz puzpuzpuz added Bug Incorrect or unexpected behavior SQL Issues or changes relating to SQL execution labels Feb 23, 2024
@puzpuzpuz puzpuzpuz self-assigned this Feb 23, 2024
@puzpuzpuz puzpuzpuz force-pushed the puzpuzpuz_first_last_sample_by_segfault branch from bc9e1d9 to 6f9684c Compare February 26, 2024 11:03
@puzpuzpuz puzpuzpuz force-pushed the puzpuzpuz_first_last_sample_by_segfault branch from 6f9684c to caa6484 Compare February 26, 2024 11:06
@puzpuzpuz puzpuzpuz marked this pull request as ready for review February 26, 2024 11:07
@puzpuzpuz puzpuzpuz requested review from ideoma and removed request for eugenels February 26, 2024 12:48
@puzpuzpuz
Copy link
Contributor Author

@ideoma Eugene told that you wrote findFirstLastInFrame0. Could you review this one when you have the time? It's not urgent.

Copy link
Collaborator

@ideoma ideoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please revert the binaries update or update them for every platform?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ puzpuzpuz
❌ GitHub Actions - Rebuild Native Libraries


GitHub Actions - Rebuild Native Libraries seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ideoma
Copy link
Collaborator

ideoma commented Feb 26, 2024

[PR Coverage check]

😍 pass : 10 / 10 (100.00%)

file detail

path covered line new line coverage
🔵 io/questdb/griffin/engine/groupby/SampleByFirstLastRecordCursorFactory.java 10 10 100.00%

@ideoma ideoma merged commit 9322151 into master Feb 27, 2024
21 of 22 checks passed
@ideoma ideoma deleted the puzpuzpuz_first_last_sample_by_segfault branch February 27, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Incorrect or unexpected behavior SQL Issues or changes relating to SQL execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segfault when running SAMPLE BY with index-based access
3 participants