Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(http): fix rejects of HTTP GET requests when content-length set to 0 #4242

Merged
merged 4 commits into from Feb 28, 2024
Merged

fix(http): fix rejects of HTTP GET requests when content-length set to 0 #4242

merged 4 commits into from Feb 28, 2024

Conversation

ideoma
Copy link
Collaborator

@ideoma ideoma commented Feb 27, 2024

fixes #4239

@ideoma
Copy link
Collaborator Author

ideoma commented Feb 28, 2024

[PR Coverage check]

😍 pass : 55 / 62 (88.71%)

file detail

path covered line new line coverage
🔵 io/questdb/cutlass/http/processors/LineHttpPingProcessor.java 0 2 00.00%
🔵 io/questdb/cutlass/http/HttpConnectionContext.java 19 21 90.48%
🔵 io/questdb/cutlass/http/HttpResponseSink.java 31 34 91.18%
🔵 io/questdb/cutlass/http/processors/TextImportProcessor.java 2 2 100.00%
🔵 io/questdb/cutlass/http/client/HttpClient.java 3 3 100.00%

@ideoma ideoma merged commit 639865c into master Feb 28, 2024
22 checks passed
@ideoma ideoma deleted the fix-http-get-rejected-404 branch February 28, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puzpuzpuz puzpuzpuz puzpuzpuz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QuestDB returns 404 on static http GET requests
2 participants
@ideoma @puzpuzpuz