perf(sql): parallel GROUP BY support for first/last functions #4267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puzpuzpuz
added
SQL
bluestreak01
reviewed
Mar 6, 2024
core/src/main/java/io/questdb/griffin/engine/functions/GroupByFunction.java
Outdated
Show resolved
Hide resolved
bluestreak01
reviewed
Mar 6, 2024
.../main/java/io/questdb/griffin/engine/functions/groupby/CountDistinctUuidGroupByFunction.java
Outdated
Show resolved
Hide resolved
bluestreak01
reviewed
Mar 6, 2024
core/src/main/java/io/questdb/griffin/engine/functions/groupby/FirstDoubleGroupByFunction.java
Show resolved
Hide resolved
bluestreak01
requested changes
Mar 6, 2024
core/src/main/java/io/questdb/griffin/engine/functions/groupby/FirstDateGroupByFunction.java
Outdated
Show resolved
Hide resolved
...c/main/java/io/questdb/griffin/engine/functions/groupby/FirstNotNullCharGroupByFunction.java
Show resolved
Hide resolved
...c/main/java/io/questdb/griffin/engine/functions/groupby/FirstNotNullDateGroupByFunction.java
Show resolved
Hide resolved
bluestreak01
reviewed
Mar 6, 2024
...java/io/questdb/griffin/engine/functions/groupby/FirstNotNullIPv4GroupByFunctionFactory.java
Show resolved
Hide resolved
[PR Coverage check]😍 pass : 657 / 825 (79.64%) file detail
|
bluestreak01
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports all
first/last/first_not_null/last_not_nullSQL functions to parallel GROUP BY.To achieve that, this patch adds
rowIdargument tocomputeFirst()/computeNext()methods of theGroupByFunctionclass. This argument contains growing non-negative numbers, so it's first/last parallel SQL functions. TherowIdvalues are also different fromrecord.getRowId()- that's because not all record classes implement that method and, for those that do, there is no growth guarantee.