Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(sql): avoid redundant parsing of UUID bind variables #4281

Merged
merged 1 commit into from Mar 9, 2024

Conversation

puzpuzpuz
Copy link
Contributor

@puzpuzpuz puzpuzpuz commented Mar 8, 2024

Also, adds bind variable support for IPv4. Before this patch, equals and comparison operators on IPv4 supported string constants, but not runtime constants (bind variables).

Also, fixes bind variable support for IPv4. Before this patch, equals
and comparison operators on IPv4 supported string constants, but not
runtime constants (bind variables).
@puzpuzpuz puzpuzpuz added Bug Incorrect or unexpected behavior SQL Issues or changes relating to SQL execution Performance Performance improvements labels Mar 8, 2024
@puzpuzpuz puzpuzpuz requested a review from jerrinot March 8, 2024 17:34
@puzpuzpuz puzpuzpuz self-assigned this Mar 8, 2024
@puzpuzpuz puzpuzpuz changed the title perf(sql): remove redundant parsing of UUID bind variables perf(sql): avoid redundant parsing of UUID bind variables Mar 8, 2024
@ideoma
Copy link
Collaborator

ideoma commented Mar 8, 2024

[PR Coverage check]

😍 pass : 220 / 267 (82.40%)

file detail

path covered line new line coverage
🔵 io/questdb/cairo/map/Unordered8Map.java 0 2 00.00%
🔵 io/questdb/cairo/map/Unordered2Map.java 0 2 00.00%
🔵 io/questdb/cairo/map/Unordered16Map.java 0 2 00.00%
🔵 io/questdb/cutlass/line/udp/LineUdpParserSupport.java 1 2 50.00%
🔵 io/questdb/cairo/map/OrderedMap.java 2 4 50.00%
🔵 io/questdb/cairo/RecordChain.java 2 3 66.67%
🔵 io/questdb/cairo/TableWriter.java 2 3 66.67%
🔵 io/questdb/griffin/TextPlanSink.java 5 7 71.43%
🔵 io/questdb/griffin/engine/functions/math/IPv4StrNetmaskFunctionFactory.java 8 11 72.73%
🔵 io/questdb/griffin/engine/functions/lt/LtIPv4StrFunctionFactory.java 36 46 78.26%
🔵 io/questdb/griffin/engine/functions/lt/LtStrIPv4FunctionFactory.java 37 45 82.22%
🔵 io/questdb/griffin/JsonPlanSink.java 5 6 83.33%
🔵 io/questdb/griffin/engine/functions/eq/IPv4EqUtils.java 27 32 84.38%
🔵 io/questdb/griffin/engine/functions/eq/UuidEqUtils.java 39 46 84.78%
🔵 io/questdb/cairo/map/Unordered4Map.java 2 2 100.00%
🔵 io/questdb/griffin/engine/functions/SwappingArgsFunctionFactory.java 6 6 100.00%
🔵 io/questdb/cairo/wal/WalWriter.java 3 3 100.00%
🔵 io/questdb/griffin/engine/functions/eq/EqStrIPv4FunctionFactory.java 7 7 100.00%
🔵 io/questdb/griffin/engine/functions/eq/EqUuidStrFunctionFactory.java 3 3 100.00%
🔵 io/questdb/cairo/RecordSinkFactory.java 4 4 100.00%
🔵 io/questdb/griffin/engine/functions/bool/InStrFunctionFactory.java 1 1 100.00%
🔵 io/questdb/cutlass/text/types/IPv4Adapter.java 1 1 100.00%
🔵 io/questdb/griffin/engine/functions/NegatingFunctionFactory.java 4 4 100.00%
🔵 io/questdb/griffin/engine/functions/bind/NamedParameterLinkFunction.java 1 1 100.00%
🔵 io/questdb/griffin/engine/functions/eq/EqStrUuidFunctionFactory.java 3 3 100.00%
🔵 io/questdb/griffin/engine/functions/lt/LtIPv4FunctionFactory.java 10 10 100.00%
🔵 io/questdb/griffin/engine/functions/eq/EqIPv4StrFunctionFactory.java 5 5 100.00%
🔵 io/questdb/griffin/engine/functions/eq/EqIPv4FunctionFactory.java 3 3 100.00%
🔵 io/questdb/griffin/RecordToRowCopierUtils.java 3 3 100.00%

@bluestreak01 bluestreak01 merged commit 5e656f6 into master Mar 9, 2024
24 checks passed
@bluestreak01 bluestreak01 deleted the puzpuzpuz_row_putipv4 branch March 9, 2024 23:06
@puzpuzpuz
Copy link
Contributor Author

@bluestreak01 thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Incorrect or unexpected behavior Performance Performance improvements SQL Issues or changes relating to SQL execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants