chore(sql): fix occasional failures with first()/last()/first_not_null()/last_not_null() direct string function #4324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puzpuzpuz
reviewed
Mar 21, 2024
core/src/main/java/io/questdb/griffin/engine/groupby/DirectStrAwareCharHolder.java
Outdated
Show resolved
Hide resolved
since not all DirectString are stable during a query execution
puzpuzpuz
reviewed
Mar 22, 2024
core/src/main/java/io/questdb/std/str/StableDirectSequence.java
Outdated
Show resolved
Hide resolved
puzpuzpuz
changed the base branch from
puzpuzpuz_fix_first_last_direct_str_functions
to
master
puzpuzpuz
changed the title
puzpuzpuz
reviewed
Mar 22, 2024
core/src/main/java/io/questdb/griffin/engine/groupby/StableAwareCharHolder.java
Outdated
Show resolved
Hide resolved
puzpuzpuz
reviewed
Mar 22, 2024
puzpuzpuz
previously approved these changes
Mar 22, 2024
core/src/test/java/io/questdb/test/griffin/engine/groupby/StableAwareStringHolderTest.java
Show resolved
Hide resolved
puzpuzpuz
approved these changes
Mar 22, 2024
jerrinot
changed the title
[PR Coverage check]😍 pass : 453 / 569 (79.61%) file detail
|
terasum
pushed a commit
to terasum/questdb
that referenced
this pull request
Mar 22, 2024
…l()/last_not_null() direct string function (questdb#4324)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #4310
the
isDirectStr()flags are gone. I created specialized sink-like holder which supports both direct and non-directs char sequences. it's not a sink since it does not support appending to previously set string. it always discard any previously held string.I'm pushing into @puzpuzpuz's branch since it's building on top of his changes and I want him to give him a chance to review it instead of doing a direct push.