Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql): fix incorrect results returned when executing lower/upper/substring functions in parallel #4337

Merged
merged 2 commits into from Mar 26, 2024

Conversation

puzpuzpuz
Copy link
Contributor

@puzpuzpuz puzpuzpuz commented Mar 25, 2024

Queries with filters like UPPER(str_col) LIKE '%FOOBAR%' returned incorrect results when present in parallel filter or GROUP BY.

The list of affected SQL functions:

  • upper/to_uppercase
  • lower/to_lowercase
  • substring
  • base64
  • quote_ident
  • size_pretty
  • concat

@puzpuzpuz puzpuzpuz added Bug Incorrect or unexpected behavior SQL Issues or changes relating to SQL execution labels Mar 25, 2024
@puzpuzpuz puzpuzpuz self-assigned this Mar 25, 2024
@ideoma
Copy link
Collaborator

ideoma commented Mar 26, 2024

[PR Coverage check]

😍 pass : 19 / 23 (82.61%)

file detail

path covered line new line coverage
🔵 io/questdb/griffin/engine/functions/str/QuoteIdentFunctionFactory.java 0 1 00.00%
🔵 io/questdb/griffin/engine/functions/bin/Base64FunctionFactory.java 3 5 60.00%
🔵 io/questdb/griffin/engine/functions/str/SizePrettyFunctionFactory.java 2 3 66.67%
🔵 io/questdb/griffin/engine/functions/str/ToUppercaseVarcharFunctionFactory.java 2 2 100.00%
🔵 io/questdb/griffin/engine/functions/str/LowerVarcharFunctionFactory.java 2 2 100.00%
🔵 io/questdb/griffin/engine/functions/str/ToLowercaseFunctionFactory.java 1 1 100.00%
🔵 io/questdb/griffin/engine/functions/str/ToLowercaseVarcharFunctionFactory.java 2 2 100.00%
🔵 io/questdb/griffin/engine/functions/str/ToUppercaseFunctionFactory.java 1 1 100.00%
🔵 io/questdb/griffin/engine/functions/str/ConcatFunctionFactory.java 1 1 100.00%
🔵 io/questdb/griffin/engine/functions/str/UpperVarcharFunctionFactory.java 2 2 100.00%
🔵 io/questdb/griffin/engine/functions/str/SubStringFunctionFactory.java 1 1 100.00%
🔵 io/questdb/griffin/engine/functions/str/SubStringVarcharFunctionFactory.java 2 2 100.00%

@ideoma ideoma merged commit 711eac3 into master Mar 26, 2024
24 checks passed
@ideoma ideoma deleted the puzpuzpuz_upper_lower_function_race branch March 26, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Incorrect or unexpected behavior SQL Issues or changes relating to SQL execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants