Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sql): fix incorrect results for parallel group by with symbol like filter #4411

Merged
merged 3 commits into from Apr 16, 2024
Merged

fix(sql): fix incorrect results for parallel group by with symbol like filter #4411

merged 3 commits into from Apr 16, 2024

Conversation

puzpuzpuz
Copy link
Contributor

For queries like SELECT key, count(*) FROM tab WHERE key like '%foobar%' ORDER BY key; filter functions were not cloned. This led to incorrect results returned by the query.

Also, cleans up isReadThreadSafe overrides to make them consistent.

@puzpuzpuz puzpuzpuz added Bug Incorrect or unexpected behavior SQL Issues or changes relating to SQL execution labels Apr 16, 2024
@puzpuzpuz puzpuzpuz self-assigned this Apr 16, 2024
@ideoma
Copy link
Collaborator

ideoma commented Apr 16, 2024

[PR Coverage check]

😍 pass : 3 / 6 (50.00%)

file detail

path covered line new line coverage
🔵 io/questdb/griffin/engine/functions/eq/EqSymStrFunctionFactory.java 3 6 50.00%

@bluestreak01 bluestreak01 merged commit c8298d6 into master Apr 16, 2024
24 checks passed
@bluestreak01 bluestreak01 deleted the puzpuzpuz_broken_sql_function_flags branch April 16, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluestreak01 bluestreak01 bluestreak01 approved these changes

Assignees

@puzpuzpuz puzpuzpuz

Labels
Bug Incorrect or unexpected behavior SQL Issues or changes relating to SQL execution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@puzpuzpuz @ideoma @bluestreak01