Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PG wire improvements. Fixes #450 #544

Merged
merged 11 commits into from Aug 13, 2020
Merged

PG wire improvements. Fixes #450 #544

merged 11 commits into from Aug 13, 2020

Conversation

jaugsburger
Copy link
Contributor

@jaugsburger jaugsburger commented Aug 10, 2020

This change deals with issues around protocol mechanics, in particular our responses to messages from the client on simple and extended mode.

For example:

  • we now wait for sync message to send reply back, therefore grouping replies. This means that if client sends messages: P/B/D/E/S, we now send one reply back with 1/2/T/D/C/Z. This means that there is less chatter on the wire because 1. we are sending less messages and 2. the client does not get confused and therefore send less messages.
  • for each message sent by client, we send an acknowledgement back
  • stop sending spurious messages
  • named prepared statements are cached on parse and we correctly bind parameters when receiving named statement on the Bind and Describe messages
  • when executing 'select', we now send back the number of returned rows
  • when executing 'set', we now send correct query tag (SET)
  • for empty queries, we reply back with correct message type
  • for queries with no data, we reply back with 'no data' message type
  • row description now includes column number
  • row descriptions attempts to populate type size and type modifier

@CLAassistant
Copy link

CLAassistant commented Aug 10, 2020

CLA assistant check
All committers have signed the CLA.

@jaugsburger jaugsburger changed the title PG wire fixes PG wire improvements. Fixes #450 Aug 12, 2020
@bluestreak01 bluestreak01 merged commit 5fad98c into master Aug 13, 2020
@bluestreak01 bluestreak01 deleted the pgwire.fixes branch August 13, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants