fix(cutlass) - PGwire fixes: support batch insert, ignore 'BEGIN', appenders. fix #145 #608 #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jaugsburger
commented
Sep 25, 2020
jaugsburger
commented
- support batch insert
- ignore 'BEGIN'
- implement char & long256 appenders
…plement char & long256 appenders
jaugsburger
requested review from
bluestreak01,
mpsq,
patrickSpaceSurfer and
TheTanc
as code owners
|
PG driver sends "describe" message with "insert" statement, to which server does not reply anything. It only replies to queries. This perhaps a protocol violation |
…rmat count and parameter value count. And extra comments for readability
…erts and other ddls
… paramenter count validation
bluestreak01
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.