-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web-console): New Import page #130
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Out with `dracula`
…tdb/ui into web-console/import-to-react
bluestreak01
previously approved these changes
May 15, 2023
argshook
approved these changes
May 15, 2023
This was referenced May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Synopsis
This PR introduces the new
Import from CSV
page, which has been redesigned and ported to React. It also utilizes @questdb/react-components package for rendering certain components.The new flow utilizes all the supported REST API features, therefore the initial file drop / add does not upload the file to the database automatically, rather it allows the user to specify everything as needed, or leave it in automatic mode, click the button, and refine later.
Upload screen (after file drop / add)
Upload screen - file has been uploaded already for the same name
Note that the table schema has been fetched and loaded into schema editor, so that user can tweak it if needed.
Upload settings drawer
Schema editor
🚧 Side changes
dracula
references) to align with @questdb/react-components config, otherwise UI components wouldn't work properly, as they rely on Styled Component's ThemeProvider at the current time.