Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web-console): Import: Handle duplicate files #155

Merged
merged 4 commits into from
Jun 1, 2023

Conversation

insmac
Copy link
Contributor

@insmac insmac commented May 31, 2023

This PR adds handling of adding multiple files of the same name to the upload queue. The current version is buggy and does not inform the user if a duplicate has been detected.

The new behavior is as follows:

  • Duplicate file names are allowed as long as the target table name is unique
  • If duplicates have been found, a relevant error message is displayed
  • Duplicates are filtered out before adding the batch to the queue.

Side changes:

  • Paste event handler has been moved to Dropbox, so that the de-duplication logic is unified and displays the same error message every time for file browsing, drag & drop and paste.

Screen recording:

CleanShot.2023-05-31.at.16.34.58.mp4

@insmac insmac merged commit 5a16309 into main Jun 1, 2023
2 checks passed
@insmac insmac deleted the web-console/import-handle-duplicates branch June 1, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants