Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 issue using the module into Magento 2.4.5 context #20

Open
gianstraf opened this issue May 3, 2023 · 0 comments
Open

PHP 8 issue using the module into Magento 2.4.5 context #20

gianstraf opened this issue May 3, 2023 · 0 comments

Comments

@gianstraf
Copy link

Hi,
due to the use of module on PHP 8.1 we have found a problem into

$cookieNameValues = explode("&", $cookieValue);

and

$arr = explode("=", $cookieNameValues[$i]);

when the second param is null (PHP Deprecated: explode(): Passing null to parameter #2).

Same problem here:

if (substr($queueDomain, -1) !== "/")

with substr function (PHP Deprecated: substr(): Passing null to parameter #1).

In our context, the module required by queueit/knownuser throws an error when used on the Magento 2.4.5 context (magento/magento2#35875).

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant