Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos on the flowcontrol page #56

Merged
merged 3 commits into from
May 7, 2024

Conversation

Wondertan
Copy link
Contributor

Minor typos and grammar fixes. It feels like the doc should go through spell checker. Otherwise, great job on the content!

Copy link

google-cla bot commented Apr 27, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@marten-seemann
Copy link
Member

Otherwise, great job on the content!

Thank you!!!

It feels like the doc should go through spell checker.

That sounds useful indeed. No worries if you don't, but do you have any recommendation / existing workflow for that?

Copy link
Member

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixes!

content/docs/quic/flowcontrol.md Outdated Show resolved Hide resolved
content/docs/quic/flowcontrol.md Outdated Show resolved Hide resolved
content/docs/quic/flowcontrol.md Outdated Show resolved Hide resolved
content/docs/quic/flowcontrol.md Outdated Show resolved Hide resolved
@marten-seemann
Copy link
Member

@Wondertan Would you mind signing the CLA?

@Wondertan
Copy link
Contributor Author

I dont mind, but can do once I back to PC in a few days

@Wondertan
Copy link
Contributor Author

but do you have any recommendation / existing workflow for that?

Personally, I use Grammarly every time I submit any text + spell check in IDE. Having some CI-based workflow that links text automatically would be neater.

I applied your suggestion and signed the CLA so it can be merged. Thanks for the review

Wondertan and others added 3 commits May 6, 2024 18:16
Minor typos and grammar fixes. It feels like the doc should go through spell checker. Otherwise, great job on the content!
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
Copy link
Member

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Wondertan!

@marten-seemann marten-seemann changed the title Update flowcontrol.md fix typos on the flowcontrol page May 7, 2024
@marten-seemann marten-seemann merged commit 21683cd into quic-go:master May 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants