Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ECN support #4059

Merged
merged 11 commits into from
Sep 11, 2023
Merged

add ECN support #4059

merged 11 commits into from
Sep 11, 2023

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Aug 31, 2023

Fixes #3999.

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #4059 (d6ac630) into master (abfe1ef) will increase coverage by 0.07%.
Report is 1 commits behind head on master.
The diff coverage is 85.82%.

@@            Coverage Diff             @@
##           master    #4059      +/-   ##
==========================================
+ Coverage   83.42%   83.49%   +0.07%     
==========================================
  Files         147      148       +1     
  Lines       14888    15220     +332     
==========================================
+ Hits        12419    12707     +288     
- Misses       1972     2010      +38     
- Partials      497      503       +6     
Files Changed Coverage Δ
internal/ackhandler/ackhandler.go 0.00% <0.00%> (ø)
internal/ackhandler/received_packet_tracker.go 82.64% <ø> (-0.14%) ⬇️
packet_handler_map.go 84.52% <ø> (ø)
sys_conn_helper_linux.go 75.41% <ø> (ø)
transport.go 72.31% <0.00%> (ø)
sys_conn.go 74.58% <33.33%> (-2.62%) ⬇️
internal/ackhandler/sent_packet_handler.go 74.61% <57.14%> (-0.67%) ⬇️
logging/multiplex.go 87.50% <66.67%> (-2.50%) ⬇️
server.go 75.93% <66.67%> (ø)
send_conn.go 86.96% <80.00%> (-0.28%) ⬇️
... and 10 more

... and 1 file with indirect coverage changes

Copy link
Collaborator

@sukunrt sukunrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have closely reviewed the ecn.go file. Will finish the review after a couple of hours.

internal/ackhandler/ecn.go Show resolved Hide resolved
internal/ackhandler/ecn.go Show resolved Hide resolved
internal/ackhandler/ecn.go Show resolved Hide resolved
internal/ackhandler/ecn.go Outdated Show resolved Hide resolved
internal/ackhandler/ecn.go Show resolved Hide resolved
internal/ackhandler/ecn.go Show resolved Hide resolved
internal/ackhandler/sent_packet_handler.go Outdated Show resolved Hide resolved
packet_packer.go Outdated Show resolved Hide resolved
send_conn.go Outdated Show resolved Hide resolved
send_conn.go Outdated Show resolved Hide resolved
@marten-seemann marten-seemann merged commit 1f25153 into master Sep 11, 2023
33 checks passed
@@ -14,6 +14,8 @@ const (
ipv4PKTINFO = 0x7
)

const ecnIPv4DataLen = 4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong: It should be 1 for FreeBSD. See https://cgit.freebsd.org/src/tree/sys/netinet/udp_usrreq.c#n1144
4 is the correct length for use with setsockopt(2) but not as a cmsg.

@marten-seemann
Copy link
Member Author

@peterjeremy You're commenting on a PR that was merged a couple of weeks ago. Please don't do this!

If you think you found an issue, please just open a new issue and we can continue discussing there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add ECN support
3 participants