-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ECN support #4059
add ECN support #4059
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4059 +/- ##
==========================================
+ Coverage 83.42% 83.49% +0.07%
==========================================
Files 147 148 +1
Lines 14888 15220 +332
==========================================
+ Hits 12419 12707 +288
- Misses 1972 2010 +38
- Partials 497 503 +6
|
cd83d50
to
691fcd6
Compare
26d2a02
to
ad78f31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have closely reviewed the ecn.go
file. Will finish the review after a couple of hours.
f90c336
to
b4f9cc1
Compare
@@ -14,6 +14,8 @@ const ( | |||
ipv4PKTINFO = 0x7 | |||
) | |||
|
|||
const ecnIPv4DataLen = 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong: It should be 1 for FreeBSD. See https://cgit.freebsd.org/src/tree/sys/netinet/udp_usrreq.c#n1144
4 is the correct length for use with setsockopt(2)
but not as a cmsg.
@peterjeremy You're commenting on a PR that was merged a couple of weeks ago. Please don't do this! If you think you found an issue, please just open a new issue and we can continue discussing there. |
Fixes #3999.