Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop duplicate packets #2569

Merged
merged 1 commit into from
May 29, 2020
Merged

drop duplicate packets #2569

merged 1 commit into from
May 29, 2020

Conversation

marten-seemann
Copy link
Member

Fixes #2568.

Duplicate detection uses the same data structure that is used to track received packets to generate ACK frames. That means that after an old ACK range has been pruned, a severly delayed packet might be incorrectly detected as a duplicate.

As we wouldn't have acknowledged receipt of this packet, this situation would have resulted in a retransmission by the peer anyway, so dropping the packet won't cause a big regression.

Duplicate detection uses the same data structure that is used to track
received packets to generate ACK frames. That means that after an old
ACK range has been pruned, a severly delayed packet might be incorrectly
detected as a duplicate.
As we wouldn't have acknowledged receipt of this packet, this situation
would have resulted in a retransmission by the peer anyway, so dropping
the packet won't cause a big regression.
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2020

Codecov Report

Merging #2569 into master will increase coverage by 0.01%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2569      +/-   ##
==========================================
+ Coverage   86.19%   86.21%   +0.01%     
==========================================
  Files         122      122              
  Lines        9583     9613      +30     
==========================================
+ Hits         8260     8287      +27     
- Misses        985      988       +3     
  Partials      338      338              
Impacted Files Coverage Δ
qlog/types.go 84.85% <0.00%> (-0.87%) ⬇️
internal/ackhandler/received_packet_handler.go 75.71% <91.67%> (+3.30%) ⬆️
internal/ackhandler/received_packet_history.go 97.33% <100.00%> (+0.36%) ⬆️
internal/ackhandler/received_packet_tracker.go 80.00% <100.00%> (+0.45%) ⬆️
session.go 75.47% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd5ecee...440ff10. Read the comment docs.

@marten-seemann marten-seemann merged commit 8d00ec1 into master May 29, 2020
@marten-seemann marten-seemann deleted the drop-duplicate-packets branch May 29, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

don't process duplicate packets
3 participants