Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: Add DialEarlyContext and DialAddrEarlyContext API #2814

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Oct 5, 2020

Fixes #2812.

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #2814 into master will decrease coverage by 2.30%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2814      +/-   ##
==========================================
- Coverage   86.02%   83.72%   -2.30%     
==========================================
  Files         133      275     +142     
  Lines       12063    22189   +10126     
==========================================
+ Hits        10376    18576    +8200     
- Misses       1355     2906    +1551     
- Partials      332      707     +375     
Impacted Files Coverage Δ
client.go 78.51% <50.00%> (+2.29%) ⬆️
internal/protocol/key_phase.go 80.00% <0.00%> (-20.00%) ⬇️
internal/testdata/cert.go 57.89% <0.00%> (-10.11%) ⬇️
internal/protocol/encryption_level.go 90.00% <0.00%> (-10.00%) ⬇️
internal/handshake/header_protector.go 78.26% <0.00%> (-6.81%) ⬇️
internal/handshake/retry.go 68.42% <0.00%> (-5.49%) ⬇️
closed_session.go 79.41% <0.00%> (-3.92%) ⬇️
buffer_pool.go 90.48% <0.00%> (-3.46%) ⬇️
internal/utils/buffered_write_closer.go 66.67% <0.00%> (-3.33%) ⬇️
http3/frames.go 74.60% <0.00%> (-3.04%) ⬇️
... and 262 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93e733a...36add0e. Read the comment docs.

@marten-seemann marten-seemann self-requested a review October 6, 2020 02:46
Copy link
Member

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This lgtm, just one suggestion:

Can you use DialAddrEarlyContext in DialAddrEarly, in order to avoid code duplication?

func DialAddrEarly(...) {
     return DialAddrEarlyContext(context.Background(), ....)
}

client.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
Copy link
Member

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow passing in context when using 0RTT
3 participants