Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only use syscalls on platforms that we're actually testing #2886

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

marten-seemann
Copy link
Member

Fixes #2880. Closes #2881.

@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #2886 (631e37c) into master (287a324) will not change coverage.
The diff coverage is 57.14%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2886   +/-   ##
=======================================
  Coverage   85.77%   85.77%           
=======================================
  Files         134      133    -1     
  Lines        9187     9187           
=======================================
  Hits         7880     7880           
  Misses        959      959           
  Partials      348      348           
Impacted Files Coverage Δ
conn_generic.go 100.00% <ø> (ø)
conn_helper_linux.go 100.00% <ø> (ø)
conn_ecn.go 70.97% <57.14%> (-4.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 287a324...631e37c. Read the comment docs.

@marten-seemann marten-seemann merged commit 69158cf into master Nov 19, 2020
@marten-seemann marten-seemann deleted the fix-syscalls branch November 20, 2020 02:25
qbit added a commit to qbit/AdGuardHome that referenced this pull request Dec 11, 2020
quic-go at version 0.19.1 has a bug that prevents it from building on systems
that don't have IP_RECVTOS.

Version 0.19.3 contains a fix:
 quic-go/quic-go#2886
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this pull request Mar 20, 2023
quic-go at version 0.19.1 has a bug that prevents it from building on systems
that don't have IP_RECVTOS.

Version 0.19.3 contains a fix:
 quic-go/quic-go#2886
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error "conn_helper_generic.go:10:60: undefined: syscall.IP_RECVTOS" in DragonFly BSD
2 participants