fix incorrect usage of errors.Is #3215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
fix-errors-is
branch
2 times, most recently
from
f9a582c
to
bac0b24
Compare
Codecov Report
@@ Coverage Diff @@
## master #3215 +/- ##
==========================================
- Coverage 85.40% 85.38% -0.02%
==========================================
Files 134 133 -1
Lines 9825 9804 -21
==========================================
- Hits 8391 8371 -20
- Misses 1060 1061 +1
+ Partials 374 372 -2
Continue to review full report at Codecov.
|
mvdan
approved these changes
Jun 28, 2021
| func (e *IdleTimeoutError) Is(target error) bool { return target == net.ErrClosed } | ||
| func (e *HandshakeTimeoutError) Is(target error) bool { return target == net.ErrClosed } | ||
| func (e *VersionNegotiationError) Is(target error) bool { return target == net.ErrClosed } | ||
| func (e *StatelessResetError) Is(target error) bool { return target == net.ErrClosed } |
There was a problem hiding this comment.
👍 not sure how I didn't catch the type assertions in the last review :)
errors.Is is supposed to used for equality of errors, not for type assertions. That's what errors.As is there for.
marten-seemann
force-pushed
the
fix-errors-is
branch
from
bac0b24
to
dbb5178
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
errors.Isis supposed to used for equality of errors, not for type assertions. That's whaterrors.Asis there for.cc @mvdan