introduce a Transport #3794
Merged
introduce a Transport #3794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
new-api
branch
12 times, most recently
from
5a5d1a6
to
d2bd22e
Compare
marten-seemann
force-pushed
the
new-api
branch
11 times, most recently
from
9a842b8
to
98af9d4
Compare
Codecov Report
@@ Coverage Diff @@
## master #3794 +/- ##
==========================================
- Coverage 84.18% 83.97% -0.21%
==========================================
Files 141 142 +1
Lines 14128 14208 +80
==========================================
+ Hits 11893 11930 +37
- Misses 1815 1846 +31
- Partials 420 432 +12
|
marten-seemann
force-pushed
the
listener-structs
branch
from
f79ed84
to
86a1234
Compare
lucas-clemente
approved these changes
May 1, 2023
| ) | ||
|
|
||
| // rawConn is a connection that allow reading of a receivedPacket. |
There was a problem hiding this comment.
Typo in a removed comment?
ydnar
reviewed
May 1, 2023
ydnar
reviewed
May 1, 2023
| // The length of the connection ID in bytes. | ||
| // It can be 0, or any value between 4 and 18. | ||
| // If unset, a 4 byte connection ID will be used. | ||
| ConnectionIDLength int |
There was a problem hiding this comment.
Maybe omit ConnectionIDLength entirely in favor of ConnectionIDGenerator?
There was a problem hiding this comment.
I consider ConnectionIDGenerator somewhat of a fringe use case. You only need it if you want to use a Connection ID-based load balancer.
ydnar
reviewed
May 1, 2023
| if t.ConnectionIDGenerator != nil { | ||
| t.connIDLen = t.ConnectionIDGenerator.ConnectionIDLen() | ||
| } else { | ||
| connIDLen := t.ConnectionIDLength |
There was a problem hiding this comment.
If (Transport).ConnectionIDLength was removed, this branch on t.isSingleUse and isServer can be eliminated.
ydnar
reviewed
May 1, 2023
marten-seemann
force-pushed
the
new-api
branch
2 times, most recently
from
c7f9709
to
5fdc5c8
Compare
Added tests. Which caught several bugs :) |
marten-seemann
force-pushed
the
new-api
branch
3 times, most recently
from
0e6f3c1
to
68ffd08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3727. Fixes #3797.