Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the new crypto/tls QUIC Transport, drop support for Go 1.19 #3860

Merged
merged 1 commit into from Jul 1, 2023

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented May 25, 2023

Fixes #2727. Fixes #3757.

Unfortunately, golang/go#60506 didn't make it into the rc, and it's unclear if it'll make it into the final release. We'll have to call DecryptSessionTicket as a workaround, which cause the initilization of the session ticket keys.

I've updated the Go 1.20 qtls fork to implement a similar API as the new crypto/tls QUIC API, but to still use the same mechanism to encode application data into the session ticket. We can backport this to the Go 1.19 fork.

@marten-seemann marten-seemann force-pushed the cryptotls-events branch 2 times, most recently from ed35f2f to 9d1ecf8 Compare June 22, 2023 10:34
@marten-seemann marten-seemann changed the title use the new crypto/tls QUIC Transport use the new crypto/tls QUIC Transport, drop support for Go 1.19 Jun 22, 2023
@marten-seemann marten-seemann force-pushed the cryptotls-events branch 4 times, most recently from 13b55bb to 3bf784f Compare June 24, 2023 21:01
@codecov
Copy link

codecov bot commented Jun 24, 2023

Codecov Report

Merging #3860 (512c06e) into master (21388c8) will decrease coverage by 0.01%.
The diff coverage is 70.02%.

❗ Current head 512c06e differs from pull request most recent head 66dbe5d. Consider uploading reports for the commit 66dbe5d to get more accurate results

@@            Coverage Diff             @@
##           master    #3860      +/-   ##
==========================================
- Coverage   83.18%   83.17%   -0.01%     
==========================================
  Files         145      146       +1     
  Lines       14587    14725     +138     
==========================================
+ Hits        12134    12247     +113     
- Misses       1974     1987      +13     
- Partials      479      491      +12     
Impacted Files Coverage Δ
interface.go 0.00% <ø> (ø)
internal/handshake/session_ticket.go 100.00% <ø> (ø)
connection.go 72.40% <30.00%> (-0.34%) ⬇️
internal/qtls/go120.go 28.99% <47.62%> (+9.42%) ⬆️
transport.go 68.67% <50.00%> (+5.80%) ⬆️
internal/qtls/go121.go 57.45% <57.45%> (ø)
internal/qtls/client_session_cache.go 58.54% <58.54%> (ø)
crypto_stream_manager.go 80.43% <72.73%> (-9.57%) ⬇️
internal/qtls/cipher_suite_go121.go 85.19% <85.19%> (ø)
internal/handshake/crypto_setup.go 56.29% <88.20%> (-5.73%) ⬇️
... and 9 more

... and 7 files with indirect coverage changes

@marten-seemann marten-seemann marked this pull request as ready for review June 24, 2023 21:27
@marten-seemann marten-seemann force-pushed the cryptotls-events branch 2 times, most recently from 704e5a3 to 883c3a3 Compare June 24, 2023 22:04
@marten-seemann marten-seemann force-pushed the cryptotls-events branch 2 times, most recently from b2f96dc to 751d540 Compare June 24, 2023 22:35
@marten-seemann marten-seemann merged commit 3d89e54 into master Jul 1, 2023
55 checks passed
@marten-seemann marten-seemann deleted the cryptotls-events branch July 1, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any way to build with gotip? Avoid relying on internals of crypto/tls
2 participants