New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use the new crypto/tls QUIC Transport, drop support for Go 1.19 #3860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
cryptotls-events
branch
5 times, most recently
from
May 25, 2023 09:23
c606fc3
to
d84910a
Compare
This was referenced May 28, 2023
marten-seemann
force-pushed
the
cryptotls-events
branch
14 times, most recently
from
May 30, 2023 15:48
f30ccff
to
0acf10f
Compare
This was referenced May 31, 2023
marten-seemann
force-pushed
the
cryptotls-events
branch
2 times, most recently
from
June 1, 2023 13:08
aa28979
to
dff1609
Compare
marten-seemann
force-pushed
the
cryptotls-events
branch
2 times, most recently
from
June 22, 2023 09:35
cf74be6
to
67ae45d
Compare
marten-seemann
force-pushed
the
cryptotls-events
branch
2 times, most recently
from
June 22, 2023 10:34
ed35f2f
to
9d1ecf8
Compare
marten-seemann
changed the title
use the new crypto/tls QUIC Transport
use the new crypto/tls QUIC Transport, drop support for Go 1.19
Jun 22, 2023
marten-seemann
force-pushed
the
cryptotls-events
branch
4 times, most recently
from
June 24, 2023 21:01
13b55bb
to
3bf784f
Compare
Codecov Report
@@ Coverage Diff @@
## master #3860 +/- ##
==========================================
- Coverage 83.18% 83.17% -0.01%
==========================================
Files 145 146 +1
Lines 14587 14725 +138
==========================================
+ Hits 12134 12247 +113
- Misses 1974 1987 +13
- Partials 479 491 +12
|
marten-seemann
force-pushed
the
cryptotls-events
branch
from
June 24, 2023 21:15
3bf784f
to
618dc26
Compare
marten-seemann
force-pushed
the
cryptotls-events
branch
2 times, most recently
from
June 24, 2023 22:04
704e5a3
to
883c3a3
Compare
marten-seemann
force-pushed
the
cryptotls-events
branch
2 times, most recently
from
June 24, 2023 22:35
b2f96dc
to
751d540
Compare
marten-seemann
force-pushed
the
cryptotls-events
branch
from
June 24, 2023 22:48
751d540
to
66dbe5d
Compare
lucas-clemente
approved these changes
Jul 1, 2023
marten-seemann
force-pushed
the
cryptotls-events
branch
from
July 1, 2023 18:01
512c06e
to
66dbe5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2727. Fixes #3757.
Unfortunately, golang/go#60506 didn't make it into the rc, and it's unclear if it'll make it into the final release. We'll have to call
DecryptSessionTicket
as a workaround, which cause the initilization of the session ticket keys.I've updated the Go 1.20 qtls fork to implement a similar API as the new crypto/tls QUIC API, but to still use the same mechanism to encode application data into the session ticket. We can backport this to the Go 1.19 fork.