Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build interop Docker image for pushes to master, and for releases #4035

Merged
merged 6 commits into from
Aug 21, 2023

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Aug 16, 2023

This PR:

  1. Builds a new interop Docker image for every push to master, so that the interop runner can always test the most recent image
  2. Tags an image for releases. Those won't be picked up by the interop runner, but can be useful for debugging.

@marten-seemann
Copy link
Member Author

@galargh Could you take a look at this PR, especially the code path for releases? I don't really know how to test this, and you have a lot more experience with GHA workflows. Thank you!

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #4035 (b12c261) into master (83c00a5) will increase coverage by 0.64%.
Report is 10 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4035      +/-   ##
==========================================
+ Coverage   82.94%   83.58%   +0.64%     
==========================================
  Files         147      147              
  Lines       14781    15120     +339     
==========================================
+ Hits        12260    12638     +378     
+ Misses       2023     1988      -35     
+ Partials      498      494       -4     

see 14 files with indirect coverage changes

Copy link
Contributor

@galargh galargh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With workflows like this one, I usually try running it on real triggers in a fork. If you're cool with the changes I proposed, I can try doing that for this repo before we merge.

.github/workflows/build-interop-docker.yml Outdated Show resolved Hide resolved
Comment on lines +7 to +8
tags:
- 'v*'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are the tags for this repo created? I'm asking because if they're created automatically with the default GitHub Actions token then this trigger won't work unfortunately. There are some workarounds for that though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently I'm pushing them manually, but I was considering adopting the uCI release workflow.
How would those workaround work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With uCI release workflows, we'd need to add a workflow_run trigger (for successful release workflow runs) to this job and then use https://github.com/pl-strflt/uci/tree/main/.github/actions/inspect-releaser to retrieve information about the release that the release workflow possibly created. You can ping me when you want to set it up, happy to help :)

.github/workflows/build-interop-docker.yml Outdated Show resolved Hide resolved
.github/workflows/build-interop-docker.yml Outdated Show resolved Hide resolved
.github/workflows/build-interop-docker.yml Outdated Show resolved Hide resolved
.github/workflows/build-interop-docker.yml Outdated Show resolved Hide resolved
Co-authored-by: Piotr Galar <piotr.galar@gmail.com>
@marten-seemann
Copy link
Member Author

I tried it out in https://github.com/quic-go/docker-test, and it seems to work:
image

Thank you for your help @galargh!

marten-seemann and others added 2 commits August 20, 2023 18:40
@marten-seemann marten-seemann changed the title ci: build interop Docker image for pushes to master, and tag releases ci: build interop Docker image for pushes to master, and tags Aug 21, 2023
@marten-seemann marten-seemann changed the title ci: build interop Docker image for pushes to master, and tags ci: build interop Docker image for pushes to master, and for releases Aug 21, 2023
@marten-seemann marten-seemann merged commit f689a5d into master Aug 21, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants