-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: build interop Docker image for pushes to master, and for releases #4035
Conversation
@galargh Could you take a look at this PR, especially the code path for releases? I don't really know how to test this, and you have a lot more experience with GHA workflows. Thank you! |
Codecov Report
@@ Coverage Diff @@
## master #4035 +/- ##
==========================================
+ Coverage 82.94% 83.58% +0.64%
==========================================
Files 147 147
Lines 14781 15120 +339
==========================================
+ Hits 12260 12638 +378
+ Misses 2023 1988 -35
+ Partials 498 494 -4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With workflows like this one, I usually try running it on real triggers in a fork. If you're cool with the changes I proposed, I can try doing that for this repo before we merge.
tags: | ||
- 'v*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are the tags for this repo created? I'm asking because if they're created automatically with the default GitHub Actions token then this trigger won't work unfortunately. There are some workarounds for that though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently I'm pushing them manually, but I was considering adopting the uCI release workflow.
How would those workaround work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With uCI release workflows, we'd need to add a workflow_run
trigger (for successful release workflow runs) to this job and then use https://github.com/pl-strflt/uci/tree/main/.github/actions/inspect-releaser to retrieve information about the release that the release workflow possibly created. You can ping me when you want to set it up, happy to help :)
Co-authored-by: Piotr Galar <piotr.galar@gmail.com>
I tried it out in https://github.com/quic-go/docker-test, and it seems to work: Thank you for your help @galargh! |
Co-authored-by: Piotr Galar <piotr.galar@gmail.com>
This PR: