-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
save the RTT in non-0-RTT session tickets #4042
save the RTT in non-0-RTT session tickets #4042
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4042 +/- ##
==========================================
+ Coverage 83.29% 83.47% +0.18%
==========================================
Files 147 147
Lines 14908 14904 -4
==========================================
+ Hits 12417 12441 +24
+ Misses 1990 1967 -23
+ Partials 501 496 -5
|
} | ||
t.Parameters = &tp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a check here that the entire ticket has been consumed (r.Len() == 0
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe it is only needed for unmarshaling non-0-RTT session ticket. A 0-RTT session ticket is end with transport parameters and unmarshaling transport parameters from session ticket always consumes all bytes of the session ticket(extra bytes would either be ignored as unknwon parameter IDs or cause an EOF error).
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
e0e27bd
to
6e985a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one small nit, and two suggestions how to improve the tests.
Thanks for all your work @tanghaowillow! |
Save the RTT in non-0RTT session tickets.
Fixes #3853 for go 1.21.