ackhandler: fix ECN mangling detection when packets are lost #4089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4089 +/- ##
==========================================
- Coverage 83.71% 83.70% -0.01%
==========================================
Files 150 150
Lines 15384 15394 +10
==========================================
+ Hits 12878 12885 +7
- Misses 2006 2008 +2
- Partials 500 501 +1
|
sukunrt
reviewed
Sep 17, 2023
internal/ackhandler/ecn.go
Outdated
| @@ -259,6 +261,18 @@ func (e *ecnTracker) HandleNewlyAcked(packets []*packet, ect0, ect1, ecnce int64 | |||
| return e.state == ecnStateCapable && newECNCE > 0 | |||
| } | |||
|
|
|||
| // detectMangling fails ECN validation if all testing packets are lost or CE-marked. | |||
| func (e *ecnTracker) detectMangling() { | |||
There was a problem hiding this comment.
NIT: detectMangling reads like it should return a bool. But I also don't have a good suggestion. The best I can think of is failIfMangled
There was a problem hiding this comment.
Makes sense, I'll take it.
sukunrt
approved these changes
Sep 17, 2023
Some of the 10 testing packets are might be lost, while others might be CE-marked. We need to detect mangling if all testing packets are either lost are CE-marked.
marten-seemann
force-pushed
the
better-ecn-mangling-detection
branch
from
b686b84
to
a7afb9f
Compare
marten-seemann
changed the base branch from
ecn-only-fail-validation-if-10-testing-packets-lost
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the 10 testing packets are might be lost, while others might be CE-marked. We need to detect mangling if all testing packets are either lost are CE-marked.
Depends on #4088.