remove shutdown method on the Connection #4249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4249 +/- ##
==========================================
- Coverage 84.15% 84.11% -0.05%
==========================================
Files 150 150
Lines 15404 15398 -6
==========================================
- Hits 12963 12951 -12
- Misses 1942 1946 +4
- Partials 499 501 +2 ☔ View full report in Codecov by Sentry. |
There's no need to have a dedicated shutdown method, as the use case (shutting down an outgoing connection attempt on context cancellation) can be achieved by using Connection.destroy.
marten-seemann
force-pushed
the
remove-connection-shutdown
branch
from
332e081
to
7c62a5e
Compare
nanokatze
pushed a commit
to nanokatze/quic-go
that referenced
this pull request
Feb 1, 2024
There's no need to have a dedicated shutdown method, as the use case (shutting down an outgoing connection attempt on context cancellation) can be achieved by using Connection.destroy.
mgjeong
pushed a commit
to mgjeong/quic-go
that referenced
this pull request
Feb 13, 2024
There's no need to have a dedicated shutdown method, as the use case (shutting down an outgoing connection attempt on context cancellation) can be achieved by using Connection.destroy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to have a dedicated shutdown method, as the use case (shutting down an outgoing connection attempt on context cancellation) can be achieved by using Connection.destroy.