Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only log the discarding of Handshake keys once #4274

Merged
merged 1 commit into from Jan 29, 2024

Conversation

marten-seemann
Copy link
Member

Fixes #4234.

Copy link

codecov bot commented Jan 28, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (808f849) 84.10% compared to head (1c514a3) 84.11%.

Files Patch % Lines
connection.go 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4274   +/-   ##
=======================================
  Coverage   84.10%   84.11%           
=======================================
  Files         150      150           
  Lines       15424    15427    +3     
=======================================
+ Hits        12972    12975    +3     
  Misses       1950     1950           
  Partials      502      502           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marten-seemann marten-seemann merged commit 940feef into master Jan 29, 2024
34 checks passed
@marten-seemann marten-seemann deleted the key-discarded-log-once branch January 29, 2024 05:51
mgjeong pushed a commit to mgjeong/quic-go that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logging: key_discarded event logged multiple times
2 participants