ackhandler: don't delay ACKs for Initial and Handshake packets #4288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
no-ack-delay-during-handshake
branch
from
67feeab
to
aae6d3a
Compare
marten-seemann
force-pushed
the
no-ack-delay-during-handshake
branch
from
aae6d3a
to
93f679e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4288 +/- ##
==========================================
+ Coverage 84.09% 84.16% +0.08%
==========================================
Files 150 150
Lines 15426 15424 -2
==========================================
+ Hits 12971 12981 +10
+ Misses 1952 1941 -11
+ Partials 503 502 -1 ☔ View full report in Codecov by Sentry. |
sukunrt
approved these changes
Jan 31, 2024
mgjeong
pushed a commit
to mgjeong/quic-go
that referenced
this pull request
Feb 13, 2024
…go#4288) * ackhandler: don't delay ACKs for Initial and Handshake packets * ackhandler: embed the receivedPacketHistory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4279.