logging: add a Close function to the Tracer #4298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
close-tracer
branch
from
97f0370
to
18ed23a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4298 +/- ##
==========================================
+ Coverage 84.12% 84.16% +0.05%
==========================================
Files 150 150
Lines 15356 15364 +8
==========================================
+ Hits 12917 12931 +14
+ Misses 1940 1935 -5
+ Partials 499 498 -1 ☔ View full report in Codecov by Sentry. |
marten-seemann
force-pushed
the
debug-tracer
branch
from
e5563ca
to
71e8b82
Compare
marten-seemann
force-pushed
the
close-tracer
branch
from
18ed23a
to
a8aff68
Compare
marten-seemann
force-pushed
the
debug-tracer
branch
from
71e8b82
to
e93189d
Compare
marten-seemann
force-pushed
the
close-tracer
branch
from
a8aff68
to
3953d9d
Compare
marten-seemann
force-pushed
the
debug-tracer
branch
from
e93189d
to
01c6b6c
Compare
marten-seemann
force-pushed
the
close-tracer
branch
from
3953d9d
to
7c55d85
Compare
marten-seemann
force-pushed
the
debug-tracer
branch
from
01c6b6c
to
fc634a6
Compare
marten-seemann
force-pushed
the
close-tracer
branch
from
7c55d85
to
e23e1d2
Compare
marten-seemann
force-pushed
the
close-tracer
branch
from
e23e1d2
to
edda702
Compare
mgjeong
pushed a commit
to mgjeong/quic-go
that referenced
this pull request
Feb 13, 2024
* logging: add a Close function to the Tracer * close the Tracer when the Transport is closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to actually use qlog with a
logging.Tracer: The qlog is flushed to disk onClose.