add a qlog tracer for events outside of QUIC connections #4305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4305 +/- ##
==========================================
+ Coverage 84.81% 84.87% +0.06%
==========================================
Files 150 151 +1
Lines 14287 14336 +49
==========================================
+ Hits 12117 12167 +50
+ Misses 1671 1670 -1
Partials 499 499 ☔ View full report in Codecov by Sentry. |
sukunrt
approved these changes
Mar 7, 2024
marten-seemann
force-pushed
the
qlog-tracer
branch
from
969a9c3
to
30e01b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By attaching a qlog tracer to the
Transport, it's now possible to log QUIC events that don't belong to any particular connection. For example, this could be Version Negotiation and Retry packets that we send, packets that we can't associate with any connection, etc.It also allows using the
Debugfunction on thelogging.Tracerto dig deeper into unexpected behavior happening in a server.