handshake: validate HKDF-Expand-Label against crypto/tls implementation #4311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4311 +/- ##
==========================================
+ Coverage 84.13% 84.17% +0.04%
==========================================
Files 150 150
Lines 15368 15368
==========================================
+ Hits 12929 12935 +6
+ Misses 1940 1935 -5
+ Partials 499 498 -1 ☔ View full report in Codecov by Sentry. |
marten-seemann
force-pushed
the
hkdf-improve-tests
branch
from
481f449
to
42eebea
Compare
sukunrt
approved these changes
Feb 5, 2024
mgjeong
pushed a commit
to mgjeong/quic-go
that referenced
this pull request
Feb 13, 2024
…on (quic-go#4311) * handshake: validate HKDF-Expand-Label against crypto/tls implementation * handshake: add a benchmark for HKDF-Expand-Label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interesting bit here is that
go:linknamealso works for methods defined on struct. We're using it here to accesscipherSuiteTLS13.expandLabel:This works since methods defined on a type are really just functions that take that type as their first parameter.