delay completion of the receive stream until the reset error was read #4460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same comment as #4445 (comment) Why does the QUIC layer need to keep a reference to the closed stream? Read after completion will error. |
sukunrt
reviewed
Apr 26, 2024
marten-seemann
force-pushed
the
receive-stream-complete-after-reset-error-read
branch
from
11bb2e7
to
82beee9
Compare
sukunrt
approved these changes
Apr 26, 2024
marten-seemann
force-pushed
the
receive-stream-complete-after-reset-error-read
branch
3 times, most recently
from
0528085
to
8495d58
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4460 +/- ##
==========================================
- Coverage 84.73% 84.73% -0.01%
==========================================
Files 152 152
Lines 14464 14478 +14
==========================================
+ Hits 12256 12267 +11
- Misses 1702 1705 +3
Partials 506 506 ☔ View full report in Codecov by Sentry. |
marten-seemann
force-pushed
the
receive-stream-complete-after-reset-error-read
branch
from
8495d58
to
1a926a8
Compare
marten-seemann
deleted the
receive-stream-complete-after-reset-error-read
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other part of #4428. Needed for #3522.
With this change, a receive stream is garbage collected only once the reset error was actually read (in
Read), or ifCancelReadwas called.