-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
15$: Website: Show error messages #258
Comments
hello strager I claim this for-hire task. I expect payment after I complete this task. I will email the quick-lint-js team if I am assigned this task. |
I was playing around with the demo and this show up when I wrote Edit 1: I am build it locally Edit 2: I guess this error is related to this TODO at loadQuickLintJS()
.then((quickLintJS) => {
function lintAndUpdate() {
synchronizeContent();
// TODO(strager): On crash, show the error to the user.
let input = codeInputElement.value;
let marks = quickLintJS.parseAndLint(input);
markEditorText(shadowCodeInputElement, window, marks);
}
codeInputElement.addEventListener("input", (event) => {
lintAndUpdate();
});
lintAndUpdate();
})
.catch((error) => {
// TODO(strager): Show this error to the user.
console.error(error);
}); |
Where you suggest I look to find where the errors come from? I looked up at I suppose the error should come from this line of code from let marks = quickLintJS.parseAndLint(input); Can you help figure out this? |
That's quick-lint-js crashing. #109 tracks fixing this.
Yes. But that's not related to this task (#258). |
I think the |
This task is talking about The (non-LSP) VS Code plugin (in |
I plan on adding some features to the vscode.h interface. I might switch the web demo over to the vscode.h interface as a result. If I do that, I think this task should be easier. |
My plan is to work at this issue at weekends. Sorry I did not made to much progress yet, I'm not too familar with c++ and with the respository. I plan finish this next weekend. |
#313 would make this task a lot easier. @matttheus, I recommend focusing on the front-end part of this task (#258). When #313 is complete, it should be easy to connect the front-end to the back-end. If you have progress already, please show it so I can avoid stepping on your toes. |
Look here #323 please. |
Commit 31a88b4 added some UI for this task. It's not touch-interface-friendly, but I hope people don't try programming on their phones. The UI doesn't show for the error documentation, but that wasn't originally part of this task. |
This task involves writing browser JS.
In the web demo (https://quick-lint-js.com/demo/), we highlight errors, but we give no indication what the error is. Include a message somewhere in the UI so people can understand the errors reported by quick-lint-js.
The text was updated successfully, but these errors were encountered: