Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TestNG SQL Listener #175

Merged
merged 2 commits into from
Mar 3, 2022
Merged

Conversation

oliver-hughes
Copy link
Contributor

#44 TestNG & Spring

Add QuickPerf SQL TestNG Listener.
Listener can be added as described here
Example usage shown here.

@jeanbisutti
Copy link
Collaborator

Many thanks for this PR.

I have allowed the CI, as it's your first PR on QuickPerf.

The builds have failed:

/home/runner/work/quickperf/quickperf/testng/testng-sql-listener/src/test/java/org/quickperf/testng/sql/QuickPerfSqlTestNGListenerTest.java:[3,28] cannot find symbol
  symbol:   class TestNGTests
  location: package org.quickperf.testng
Error:  /home/runner/work/quickperf/quickperf/testng/testng-sql-listener/src/test/java/org/quickperf/testng/sql/QuickPerfSqlTestNGListenerTest.java:[15,9] cannot find symbol
  symbol:   class TestNGTests
  location: class org.quickperf.testng.sql.QuickPerfSqlTestNGListenerTest
Error:  /home/runner/work/quickperf/quickperf/testng/testng-sql-listener/src/test/java/org/quickperf/testng/sql/QuickPerfSqlTestNGListenerTest.java:[15,35] cannot find symbol
  symbol:   variable TestNGTests
  location: class org.quickperf.testng.sql.QuickPerfSqlTestNGListenerTest
Error:  /home/runner/work/quickperf/quickperf/testng/testng-sql-listener/src/test/java/org/quickperf/testng/sql/QuickPerfSqlTestNGListenerTest.java:[18,20] package TestNGTests does not exist

Adding this dependency to the new Maven module should fix the issue:

        <dependency>
            <groupId>org.quickperf</groupId>
            <artifactId>quick-perf-testng-test-util</artifactId>
            <version>1.1.1-SNAPSHOT</version>
            <classifier>tests</classifier>
            <type>test-jar</type>
            <scope>test</scope>
        </dependency>

Could you also please add a license header to each new file?

Thank you.

@jeanbisutti
Copy link
Collaborator

Great! Thank you!

Close #44

@jeanbisutti jeanbisutti merged commit 7b9487a into quick-perf:master Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants