Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Nimble] Unify negative fail messages #69

Closed
bryanenders opened this issue Jun 26, 2014 · 3 comments
Closed

[Nimble] Unify negative fail messages #69

bryanenders opened this issue Jun 26, 2014 · 3 comments
Labels
easy contribution enhancement help wanted

Comments

@bryanenders
Copy link
Member

The negative fail messages should use either not to or to not. As it is now some use the former while others use the latter. This is likely a result of there being both a notTo and toNot in Quick. We should decide on which one to use for negative fail messages. Either form is grammatically correct English.
@modocache
Copy link
Member

I agree that all failure messages should use one or the other. It seems like every matcher besides Contain uses "not to" right now, so let's use that as the standard.

Just to be clear, I think we absolutely should include both toNot and notTo methods, though. I think we agree on this one, right?

@bryanenders
Copy link
Member Author

@modocache Sounds good, and we do agree that both methods are worth keeping.

modocache added a commit that referenced this issue Jun 27, 2014
@modocache
Merge pull request #72 from endersstocker/not-to
60e9b82 
[Nimble] Changed `to not` to `not to` throughout, per issue #69
@modocache
Copy link
Member

Fixed in #72. Thanks, @endersstocker!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy contribution enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@modocache @bryanenders