Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should never happen: FOund a history with no enteries #71

Open
VladimirAkopyan opened this issue Oct 2, 2017 · 3 comments
Open

Should never happen: FOund a history with no enteries #71

VladimirAkopyan opened this issue Oct 2, 2017 · 3 comments
Labels
Milestone

Comments

@VladimirAkopyan
Copy link
Member

What is it and why is it a problem?

@VladimirAkopyan VladimirAkopyan modified the milestones: 1.8, 1.9 Oct 2, 2017
@VladimirAkopyan
Copy link
Member Author

This happens in a block that tries to get find the latest download for a given device. If that device has no data in the latest SensorHistory, we throw a warning. In reality, doing so is totally unnecessary.
Need to just decide what to do in this case. Related to #77

@VladimirAkopyan
Copy link
Member Author

I should edit the method to go back in time until it can find a SensorHistory record for that device. then we query from there, onwards.
That way we have a consistent logic - the app only trusts the datapoints themselves as date-stamps. Nothing else qualifies. If you created 50 days after that - well, what the hell is creating all the data??

@VladimirAkopyan
Copy link
Member Author

#83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant