Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shellcheck #38

Closed
daPhipz opened this issue May 7, 2020 · 0 comments
Closed

Add shellcheck #38

daPhipz opened this issue May 7, 2020 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@daPhipz
Copy link
Member

daPhipz commented May 7, 2020

I'm being completely honest with you all - I have not very much experience with coding and stuff, but I already wrote shell scripts myself and "sort of" can say what this script is doing from looking at the code.

Looking at your desktopify project, I noticed someone implementing automated shellcheck checks for every PR via GitHub Actions.
Do we want something similar here as well?

I will attempt to fix all the warnings and errors that the current version of quickemu will throw at me as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants