New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a small collection of requested features and fixes #1199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- --kill works - but still seeing the qemu-img output 😕
- --offline works
LGTM but I have uneasy feelings that more testing is needed (and I can't 'til tonight)
exit 1 | ||
fi | ||
|
||
if [ -e "${disk_img}" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It must be somewhere else still:
quickemu --vm alpine-latest.conf --kill
qemu-img: Could not open 'alpine-latest/disk.qcow2': Failed to get shared "write" lock
Is another process using the image [alpine-latest/disk.qcow2]?
VM already started!
Killing alpine-latest
- alpine-latest (6798) killed.
we send the monitor command now, and quit works OK I think maybe an |
This looks like the culprit for this:
Agreed offline works though 👍 |
Use the traditional default of qcow2, running qemu-img while a VM is running will return bogus information.
@philclifford and @popey Thanks for the feedback, there was quite a few logic bombs in there. Please test this branch again and let me know how it goes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
New features all good and --monitor-cmd works normally again.
A little casual testing with assistance of Old Peculiar seems satisfactory. 🤞
No description provided.