Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes nix flakes by adding version to package.nix #1305

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

mystery3525
Copy link
Contributor

Essentially, when you try and import the project directly with nix flakes, you receive a missing 'name' attribute error. This is because 'name' is supposed to be defined in stdenv.mkDerivation, but is not. I looked into it and found that name is actually <pname>-<version>, so I just added it.

Below are the before and after outputs of flake.nix using nix flake show:

Before:

image

After:

image

@mystery3525
Copy link
Contributor Author

mystery3525 commented Jun 25, 2024

I was looking at how we did versioning and thought that having to update the version in two different places is too much work, so I discovered a neat approach by facebook/hhvm where they dynamically pull the version from a file, and applied that here with readonly VERSION="...", so you shouldn't have to worry about updating the nix flake version.

@flexiondotorg flexiondotorg merged commit a85bb08 into quickemu-project:master Jun 25, 2024
1 check passed
@mystery3525 mystery3525 deleted the patch-3 branch June 25, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants