Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Void Linux support #321

Closed
wants to merge 6 commits into from
Closed

add Void Linux support #321

wants to merge 6 commits into from

Conversation

zen0bit
Copy link
Contributor

@zen0bit zen0bit commented Jan 16, 2022

No description provided.

@daPhipz
Copy link
Member

daPhipz commented Jan 16, 2022

Thanks for your contribution!
Do you know if there is an icon for Void Linux (preferably in SVG format) that we could use in Quickgui?

@daPhipz daPhipz mentioned this pull request Jan 16, 2022
Open
99 tasks
@zen0bit
Copy link
Contributor Author

zen0bit commented Jan 18, 2022 •
edited
Loading

what about this one?
oSoWoSo:add-void.svg

@zen0bit
Copy link
Contributor Author

zen0bit commented Jan 24, 2022

Icon merged...

philclifford
philclifford reviewed Jan 30, 2022
View reviewed changes
quickget Outdated Show resolved Hide resolved
philclifford
philclifford reviewed Jan 30, 2022
View reviewed changes
quickget Outdated Show resolved Hide resolved
philclifford
philclifford requested changes Jan 30, 2022
View reviewed changes
Copy link
Contributor

@philclifford philclifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove line 902 in quickget so this doesn't break it completely. Thanks.

philclifford
philclifford approved these changes Jan 30, 2022
View reviewed changes
Copy link
Contributor

@philclifford philclifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zen0bit, much appreciated.

@zen0bit zen0bit changed the title added initial support for void linux add support for void linux Jan 31, 2022
@zen0bit
Copy link
Contributor Author

zen0bit commented Jan 31, 2022

I think could be merged...
check it

@zen0bit zen0bit changed the title add support for void linux add Void Linux support Jan 31, 2022
philclifford
philclifford approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@philclifford philclifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks - they all pull nicely. A bit late for having a look at void but I'm looking forward to it when time permits. Cheers.

This was referenced Jan 31, 2022
Merged
Closed
@philclifford
Copy link
Contributor

In case it helps get them in I have merged into my consolidations of new distros and dealt with the conflicts that would have arisen. Here's hoping one way or another this will get in. Thanks for the quick work today - it may prove timely.

@zen0bit
Copy link
Contributor Author

zen0bit commented Jan 31, 2022

Just changed repository to original one..
Next step will be: Auto choose best mirror...

@flexiondotorg
Copy link
Member

Merged via #322

@zen0bit zen0bit deleted the void branch February 22, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philclifford philclifford philclifford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zen0bit @daPhipz @philclifford @flexiondotorg