Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FreeDOS support #374

Merged
merged 8 commits into from
Feb 24, 2022
Merged

Add FreeDOS support #374

merged 8 commits into from
Feb 24, 2022

Conversation

nqvrg
Copy link
Contributor

@nqvrg nqvrg commented Feb 21, 2022

Adds support for FreeDOS versions 1.2 and 1.3 to quickget and quickemu.

There is one small issue I couldn't figure out how to solve yet:

The live session from version 1.3 works great, but when installing (both versions), after partitioning the disk, FreeDOS needs to reboot. Upon reboot, the ISO image is disabled and QEMU attempts to boot from disk, but the system is not yet installed.
I was able to complete the installation by booting QEMU directly from the command line, to make sure it works correctly, but I wasn't able to integrate it correctly into Quickemu.

I'll try to come up with a solution, but any suggestions would be welcome.

Worst case scenario, we could keep support for FreeDOS just as a live system, but it would be great to install it too.

@nqvrg nqvrg changed the title Add freedos Add FreeDOS Feb 21, 2022
@nqvrg nqvrg changed the title Add FreeDOS Add FreeDOS support Feb 21, 2022
@flexiondotorg
Copy link
Member

Perhaps preventing the ISO image from being unmounted when running FreeDOS will help? See this line: https://github.com/quickemu-project/quickemu/blob/master/quickemu#L620

@nqvrg
Copy link
Contributor Author

nqvrg commented Feb 22, 2022

Thanks @flexiondotorg for your comment, I also thought about that.

However, Quickemu seems to be detecting correctly that the hard drive is not yet used. It says it's going to boot from the ISO, but QEMU doesn't seem to care and still tries to boot from disk.

Example:

  • I run quickemu --vm freedos-1.2.conf for the first time.
  • I partition the disk with the installer.
  • I'm asked to reboot, I answer yes.
  • QEMU tries to boot from hard drive.
  • I close the QEMU window.
  • I run quickemu --vm freedos-1.2.conf again.
  • I see this message:
     - Disk:     freedos-1.2/disk.qcow2 (16G)
                 Looks unused, booting from freedos-1.2/FD12CD.iso
     - Boot ISO: freedos-1.2/FD12CD.iso
    
  • QEMU still tries to boot from hard disk.

I'm still not quite sure if I found a but or if I'm missing something... 🤔

@daPhipz
Copy link
Member

daPhipz commented Feb 22, 2022

Is there an SVG icon of some sorts that we could use for Quickgui?

@nqvrg
Copy link
Contributor Author

nqvrg commented Feb 23, 2022

@nqvrg
Copy link
Contributor Author

nqvrg commented Feb 24, 2022

I think this is ready to go now. I hope it works correctly for everyone!

@flexiondotorg flexiondotorg merged commit ebc83eb into quickemu-project:master Feb 24, 2022
deraffe pushed a commit to deraffe/quickemu that referenced this pull request Apr 11, 2023
* Add support for FreeDOS 1.2 to quickget

* Add support for freedos guests to quickemu

* Add support for FreeDOS 1.3 to quickget

* Force qemu to keep booting from cd after formatting disk

* Adjust VM settings

* Refactor FreeDOS to use create_vm

* Add FreeDOS to README

* Add unzip to README as a dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants