Add UI settings #1055
Draft
Add UI settings #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JosteinLindhom
commented
Feb 28, 2024
JosteinLindhom
commented
- feat(state): add settings namespace to Overmind configuration
- feat(ui): set up route and button for a settings page
- feat(ui): add settings components for changing UI elements
- feat(ui): add theme provider that update CSS variables when state changes
- fix: add missing settings route
The settings namespace is used to keep track of and persist (to local storage) user selected settings.
Current implemented setting options include: - Selecting between three predefined color pairs for the pass/fail indicator for tests / criterion - Selecting custom colors for the above (this might be overkill) - Adjusting the width of the pass/fail indicator
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1055 +/- ##
==========================================
- Coverage 40.39% 40.23% -0.17%
==========================================
Files 110 91 -19
Lines 9019 6935 -2084
==========================================
- Hits 3643 2790 -853
+ Misses 5041 3845 -1196
+ Partials 335 300 -35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Should this be linked with #1049 and taken out of draft mode? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.