Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required component in group #148

Merged
merged 2 commits into from Nov 23, 2017
Merged

Conversation

mmitya
Copy link
Contributor

@mmitya mmitya commented Nov 3, 2017

This PR fixes the following problem:

  • Field "F" belongs to component "C"
  • Field "F" is marked as req'd within the component "C"
  • Component "C" belongs to repeating group "G"
  • Component "C" is marked as req'd within the group "G"

Expected: field "F" is req'd within the group "G", but validation ignores it.

For my own reference: PROM-4700.

Dmytro Mykhailov added 2 commits November 3, 2017 13:35
1. this field is req'd within a component
2. this component is req'd within a group
@chrjohn
Copy link
Member

chrjohn commented Nov 6, 2017

Thanks for the PR, will have a look at it later.

@chrjohn chrjohn added this to the QFJ 2.0.1 milestone Nov 6, 2017
@philipwhiuk
Copy link
Contributor

Nice. LGTM.

@chrjohn chrjohn merged commit 7afb9f3 into quickfix-j:master Nov 23, 2017
@chrjohn chrjohn modified the milestones: QFJ 2.0.1, QFJ 2.1.0 Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants